Chore: Update Makefile to support go workspace #83549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana-pr-automation
bot
added
type/build-packaging
type/ci
toddtreece
force-pushed
the
toddtreece/go-workspace-updates
branch
2 times, most recently
from
0ed4645
to
20b6547
Compare
toddtreece
force-pushed
the
toddtreece/go-workspace-updates
branch
from
20b6547
to
c900657
Compare
toddtreece
force-pushed
the
toddtreece/go-workspace-updates
branch
from
c900657
to
60ccc41
Compare
toddtreece
commented
Feb 29, 2024
| @@ -96,6 +96,7 @@ def pr_pipelines(): | |||
| test_backend( | |||
| get_pr_trigger( | |||
| include_paths = [ | |||
| "Makefile", | |||
There was a problem hiding this comment.
changing the makefile didn't trigger go tests
There was a problem hiding this comment.
Oh I see, you already addressed it.
There was a problem hiding this comment.
yeah, sorry, the way i worded that wasn't clear
toddtreece
force-pushed
the
toddtreece/go-workspace-updates
branch
from
60ccc41
to
34508b0
Compare
toddtreece
added
no-backport
charandas
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds support for the multi-module workspace in
make test-goand make lint-go` targets.Why do we need this feature?
Sub packages are skipped when using
.... See golang/go#50745 for more info.Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: