Reducers: Add in basic Percentile Support #85554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timlevett
requested review from
leeoniya and
baldm0mma
and removed request for
a team
timlevett
changed the title
leeoniya
reviewed
Apr 3, 2024
baldm0mma
reviewed
Apr 3, 2024
| @@ -28,6 +28,106 @@ export enum ReducerID { | |||
| allIsNull = 'allIsNull', | |||
| allValues = 'allValues', | |||
| uniqueValues = 'uniqueValues', | |||
| p1 = 'p1', | |||
There was a problem hiding this comment.
Ooof, @timlevett you're right, this is rough! 😊 We could remove the p values and replace it with something like this?
function generatePercentiles() {
const percentiles: { [key: string]: string } = {};
for (let i = 1; i <= 99; i++) {
percentiles[`p${i}`] = `p${i}`;
}
return percentiles;
}
export enum ReducerID {
...generatePercentiles(),
}
?
There was a problem hiding this comment.
ah clever, i didn't know you could do that with an enum! TIL. Will change.
There was a problem hiding this comment.
I tried to do this but enum doesn't allow dynamic additions :(
There was a problem hiding this comment.
TS, c'mon! Well, we tried! ;)
baldm0mma
reviewed
Apr 3, 2024
| for (let i = 1; i < 100; i++) { | ||
| const percentile = i / 100; | ||
| const id = `p${i}` as ReducerID; | ||
| const nth = (n: number) => n>3&&n<21?"th":n%10===1?"st":n%10===2?"nd":n%10===3?"rd":"th"; |
There was a problem hiding this comment.
You can thank the internet for that one 😂
…alculation is more accurate
leonorfmartins
pushed a commit
that referenced
this pull request
Apr 9, 2024
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
As a user I want to be able to quickly calculate various percentiles on my data, both in group by transformations and in legends, or wherever else reducers are used.
Screenshare.-.2024-04-03.1_11_18.PM.mp4
Update: Based off of offline chatter, changed to generate p1 through p99.
Why do we need this feature?
It's so nice to be able to understand percentiles as they a much better statistic than mean (averages). There is a joke, if Bill Gates walks into a bar, on average everyone is a millionaire. Its a mean joke... Having percentiles will help reduce (no pun intended) any misguidance that mean is giving people.
Who is this feature for?
Stats nerds, or anyone who is interested in learning better estimations.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: