Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducers: Update percentile logic - move percentiles to after standard reducers #86004

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

baldm0mma
Copy link
Contributor

What is this feature?

This will update the logic that was first created here. All 99 percentiles show when the reducer options are fetched from the registry - and they also show in order before all other reducer options, making them an issue to bypass. This changes that behavior to only showing the percentiles after the standard field reducers.

NOTE: this PR is in favor of #85831

Why do we need this feature?

UX needed an update.

Who is this feature for?

All users.

Which issue(s) does this PR fix?:

Fixes #85828

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@baldm0mma baldm0mma self-assigned this Apr 11, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 11, 2024
@baldm0mma baldm0mma added area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes internal for issues made by grafanistas area/legend labels Apr 11, 2024
@baldm0mma baldm0mma marked this pull request as ready for review April 11, 2024 21:15
@baldm0mma baldm0mma requested a review from a team as a code owner April 11, 2024 21:15
@baldm0mma baldm0mma requested review from codeincarnate and nmarrs and removed request for a team April 11, 2024 21:15
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and LGTM - UX still does feel a little crowded though but this is an improvement :)

An idea for how to improve this UX in the future would potentially just have a X % percentile option where user can somehow specify a number between 1-99 (dropping the number of options from 99 (bottles of beer on the wall 😬) to 1)

@baldm0mma
Copy link
Contributor Author

tested locally and LGTM - UX still does feel a little crowded though but this is an improvement :)

An idea for how to improve this UX in the future would potentially just have a X % percentile option where user can somehow specify a number between 1-99 (dropping the number of options from 99 (bottles of beer on the wall 😬) to 1)

100% agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend area/legend internal for issues made by grafanistas no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend: Percentile value options displaying all percentile options
2 participants