Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Fix A11y in AutoRefresh input field #86058

Conversation

joannaWebDev
Copy link
Contributor

What is this feature?

This PR addresses the A11y concern of the AutoRefresh input inside the dashboard feature not specifying the clear format of the data the user needs to insert.

Why do we need this feature?

Relevant WCAG Criteria: [#.#.# WCAG Criterion](link to https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0)
3.3.2 Labels or Instructions: https://www.w3.org/TR/WCAG21/#labels-or-instructions

Which issue(s) does this PR fix?:

Usage:

UI changes

Before After
Before After

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2024

CLA assistant check
All committers have signed the CLA.

@grafana-pr-automation grafana-pr-automation bot added area/frontend pr/external This PR is from external contributor labels Apr 12, 2024
@joannaWebDev joannaWebDev changed the title Dashboard: Fix A11y in AutoRefresh input field Dashboard: Fix A11y in AutoRefresh input field Apr 12, 2024
@joannaWebDev joannaWebDev marked this pull request as ready for review April 15, 2024 12:29
@joannaWebDev joannaWebDev requested a review from a team as a code owner April 15, 2024 12:29
@joannaWebDev joannaWebDev requested review from ivanortegaalba and Sergej-Vlasov and removed request for a team April 15, 2024 12:29
@joannaWebDev joannaWebDev changed the title Dashboard: Fix A11y in AutoRefresh input field Dashboard: Fix A11y in AutoRefresh input field Apr 15, 2024
@ivanortegaalba
Copy link
Contributor

Hi @joannaWebDev, thank you so much for contributing to Grafana!

From the engineering side, it looks good! Let me ask my colleagues from UX and docs to see if they are happy with the copies and we can merge it :)

@Ijin08 @imatwawana

Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@linoman linoman added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Apr 17, 2024
@linoman linoman added this to the 11.1.x milestone Apr 17, 2024
@linoman linoman merged commit 65951c4 into grafana:main Apr 17, 2024
33 checks passed
@linoman
Copy link
Contributor

linoman commented Apr 17, 2024

@joannaWebDev Thank you so much for your contribution to Grafana!

@kevinwcyu kevinwcyu modified the milestones: 11.1.x, 11.1.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y: Some input fields do not provide instructions for data formats above, below or before of the input field
6 participants