Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XYChart2: Remove common series name from tooltip items #86739

Merged
merged 1 commit into from Apr 23, 2024
Merged

XYChart2: Remove common series name from tooltip items #86739

merged 1 commit into from Apr 23, 2024

Conversation

leeoniya
Copy link
Contributor

@leeoniya leeoniya commented Apr 23, 2024 •
edited

Fixes #85027

can test in MPG/Acceleration panel in gdev: http://localhost:3000/d/YObbMr44k/panel-tests-xy-chart?orgId=1

@leeoniya leeoniya added area/panel/xychart no-changelog Skip including change in changelog/release notes backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 23, 2024
@leeoniya leeoniya added this to the 11.0.x milestone Apr 23, 2024
@leeoniya leeoniya self-assigned this Apr 23, 2024
@leeoniya leeoniya requested a review from a team as a code owner April 23, 2024 03:07
@leeoniya leeoniya requested review from Develer and nmarrs and removed request for a team April 23, 2024 03:07
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 11.0.x, 11.1.x Apr 23, 2024
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

Hello @leeoniya!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

nmarrs
nmarrs approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leeoniya leeoniya enabled auto-merge (squash) April 23, 2024 03:19
@leeoniya leeoniya merged commit 7754d0d into main Apr 23, 2024
32 checks passed
@leeoniya leeoniya deleted the leeoniya/xychart-tooltip-series-labels branch April 23, 2024 03:24
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 23, 2024
@leeoniya @grafana-delivery-bot
XYChart2: Remove common series name from tooltip items (#86739)
3b57b64 
(cherry picked from commit 7754d0d)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Apr 23, 2024
Merged
leeoniya added a commit that referenced this pull request Apr 23, 2024
@grafana-delivery-bot @leeoniya
[v11.0.x] XYChart2: Remove common series name from tooltip items (#86740
8979111 
)

XYChart2: Remove common series name from tooltip items (#86739)

(cherry picked from commit 7754d0d)

Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
@leeoniya leeoniya mentioned this pull request Apr 30, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarrs nmarrs nmarrs approved these changes

@Develer Develer Awaiting requested review from Develer Develer is a code owner automatically assigned from grafana/dataviz-squad

Assignees

@leeoniya leeoniya

Labels
area/frontend area/panel/xychart backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

XYChart2: Strip common parts from series labels in tooltips with partitioned datasets
2 participants
@leeoniya @nmarrs