XYChart2: Fix tooltip mode #87147
Merged
XYChart2: Fix tooltip mode #87147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adela-almasan
added
area/frontend
area/panel/xychart
no-changelog
adela-almasan
requested review from
leeoniya and
baldm0mma
and removed request for
a team
leeoniya
approved these changes
Apr 30, 2024
|
This PR must be merged before a backport PR will be created. |
leeoniya
reviewed
Apr 30, 2024
| @@ -24,7 +24,7 @@ export interface Props { | |||
| } | |||
|
|
|||
| function stripSeriesName(fieldName: string, seriesName: string) { | |||
| if (fieldName.includes(' ')) { | |||
| if (fieldName !== seriesName && fieldName.includes(' ')) { | |||
There was a problem hiding this comment.
(this is fixing a regression from #86739)
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit 4312f2a)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: tooltip visibility after switching between hidden/single mode; series name
xy_tooltip.mov
Fixes #85368
Please check that: