New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Upgrade otel dependencies #86994
Conversation
go.mod
Outdated
@@ -469,3 +469,5 @@ exclude github.com/mattn/go-sqlite3 v2.0.3+incompatible | |||
|
|||
// Use our fork xorm. go.work currently overrides this and points to the local ./pkg/util/xorm directory. | |||
replace xorm.io/xorm => github.com/grafana/grafana/pkg/util/xorm v0.0.1 | |||
|
|||
replace github.com/grafana/grafana-plugin-sdk-go => github.com/grafana/grafana-plugin-sdk-go v0.227.1-0.20240426134450-5fe9f7b9dfd4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be in go.work so that it is used in all sub-modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. When new release of SDK is tagged the replace is removed and go.mod files updated in each module. I guess you mean for the purpose of testing these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice with a similar command go mod edit -replace github.com/grafana/grafana-plugin-sdk-go=github.com/grafana/grafana-plugin-sdk-go@5fe9f7b9dfd42396cc596c72084afbb3ffc39f28
for go work
. Guess that doesn't exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did update go.work instead. Was a bit weird since I first had to add it to go.mod with a go mod edit as above and then go mod tidy
and then move the replace line into go.work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upgrades all otel dependencies to latest versions.
Dependent on grafana/grafana-plugin-sdk-go#967