Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshots: Render Dashboard controls in Scenes View #87972

Merged
merged 1 commit into from
May 16, 2024
Merged

Snapshots: Render Dashboard controls in Scenes View #87972

merged 1 commit into from
May 16, 2024

Conversation

evictorero
Copy link
Contributor

What is this feature?

Brings back the Dashboard controls to Snapshots in the Scenes view.
This is a regression from this PR

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@evictorero evictorero added type/bug no-changelog Skip including change in changelog/release notes backport v11.0.x Mark PR for automatic backport to v11.0.x labels May 16, 2024
@evictorero evictorero requested a review from a team as a code owner May 16, 2024 11:16
@evictorero evictorero requested review from bfmatei and Sergej-Vlasov and removed request for a team May 16, 2024 11:16
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 16, 2024
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@evictorero evictorero merged commit 5ce2d4e into main May 16, 2024
25 of 26 checks passed
@evictorero evictorero deleted the evictorero/snapshots-scenes-fix-dashboard-controls branch May 16, 2024 15:22
grafana-delivery-bot bot pushed a commit that referenced this pull request May 16, 2024
@evictorero @grafana-delivery-bot
Snapshots: Render Dashboard controls in Scenes View (#87972)
4fb18ee 
(cherry picked from commit 5ce2d4e)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request May 16, 2024
Merged
3 tasks
evictorero added a commit that referenced this pull request May 16, 2024
@grafana-delivery-bot @evictorero
[v11.0.x] Snapshots: Render Dashboard controls in Scenes View (#87993)
2c2835b 
Snapshots: Render Dashboard controls in Scenes View (#87972)

(cherry picked from commit 5ce2d4e)

Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com>
@evictorero evictorero mentioned this pull request May 16, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanicabanas juanicabanas juanicabanas approved these changes

@bfmatei bfmatei Awaiting requested review from bfmatei bfmatei is a code owner automatically assigned from grafana/dashboards-squad

@Sergej-Vlasov Sergej-Vlasov Awaiting requested review from Sergej-Vlasov Sergej-Vlasov is a code owner automatically assigned from grafana/dashboards-squad

Assignees
No one assigned
Labels
area/frontend backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/bug
Projects
Sharing squad
Archived in project
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evictorero @juanicabanas