Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshots: Add e2e test for Scenes view #88003

Merged
merged 1 commit into from
May 23, 2024
Merged

Snapshots: Add e2e test for Scenes view #88003

merged 1 commit into from
May 23, 2024

Conversation

evictorero
Copy link
Contributor

What is this feature?

I've created a simple e2e test with the goal of catch early Snapshots rendering problems on Scenes.
This test would have caught early these two issues #87972 and #87769

I've also added support for running the scenes e2e suite in dev mode.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@evictorero evictorero added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 16, 2024
@evictorero evictorero requested review from a team as code owners May 16, 2024 18:56
@evictorero evictorero requested review from dprokop, kaydelaney, joshhunt and eledobleefe and removed request for a team May 16, 2024 18:56
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 16, 2024
@evictorero evictorero self-assigned this May 20, 2024
@evictorero evictorero merged commit 6e88802 into main May 23, 2024
28 of 29 checks passed
@evictorero evictorero deleted the evictorero/snapshots-e2e-scenes-test branch May 23, 2024 13:35
ryantxu pushed a commit that referenced this pull request May 24, 2024
@evictorero @ryantxu
Snapshots: Add e2e test for Scenes view (#88003)
b1ef38f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanicabanas juanicabanas juanicabanas approved these changes

@dprokop dprokop Awaiting requested review from dprokop dprokop is a code owner automatically assigned from grafana/dashboards-squad

@kaydelaney kaydelaney Awaiting requested review from kaydelaney kaydelaney is a code owner automatically assigned from grafana/dashboards-squad

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@evictorero evictorero

Labels
area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
Sharing squad
Status: 🚀 Done
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evictorero @juanicabanas