Tempo: Send current filters when retrieving tags for AdHocFilters #88270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joey-grafana
added
area/frontend
add to changelog
area/datasource
area/datasource/frontend
area/tracing
datasource/Tempo
no-backport
adrapereira
approved these changes
Jun 4, 2024
Comment on lines
195
to
199
| if (query) { | ||
| options = await this.languageProvider.getOptionsV2(scopeAndTag, query); | ||
| } else { | ||
| options = await this.languageProvider.getOptionsV2(scopeAndTag); | ||
| } |
There was a problem hiding this comment.
We don't need this check since query is already optional in getOptionsV2
joey-grafana
deleted the
joey/tempo-send-current-filters-when-retrieving-tags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Sends current filters when retrieving tags for AdHocFilters.
Why do we need this feature?
More specific tags will be returned i.e. tags that will result in data being returned in the query.
Who is this feature for?
Tempo users.
Which issue(s) does this PR fix?:
Fixes grafana/explore-traces#35