Graphite 1.0 functions #8987
Merged
Graphite 1.0 functions #8987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderzobnin
commented
Aug 4, 2017
| @@ -11,6 +11,7 @@ export function GraphiteDatasource(instanceSettings, $q, backendSrv, templateSrv | |||
| this.basicAuth = instanceSettings.basicAuth; | |||
| this.url = instanceSettings.url; | |||
| this.name = instanceSettings.name; | |||
| this.graphiteVersion = instanceSettings.jsonData.graphiteVersion || '0.9'; | |||
There was a problem hiding this comment.
Should we additionally check instanceSettings.jsonData?
instanceSettings.jsonData = instanceSettings.jsonData || {};There was a problem hiding this comment.
I fixed unit tests, but maybe better to check this instead. When I'm loading DS with old settings, seems, instanceSettings contains empty jsonData anyway. But not sure how it works in previous grafana versions.
|
Also, haven't implemented linearRegressionAnalysis, don't understand is it applied to one series or to seriesList. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new Graphite 1.0 functions (issue #8261) and new graphite data source option graphite version, which allows user to specify its' graphite version and filter functions related only to this particular version (issue #4622).
Note: some functions were existed, but caused an error when applying it to graphite 0.9.x. These functions were marked as
1.0-specific.