New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphite 1.0 functions #8987
Merged
torkelo
merged 5 commits into
grafana:master
from
alexanderzobnin:graphite-1.0-functions
Aug 7, 2017
Merged
Graphite 1.0 functions #8987
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
215c74e
graphite-ds: add graphite version to config editor
alexanderzobnin e0f7a54
graphite-ds: modify add-graphite-function to show only version-relate…
alexanderzobnin b17cb88
graphite-ds: refactor, move func filtering to gfunc.js
alexanderzobnin 8eeca65
graphite-ds: add new functions for graphite 1.0.x
alexanderzobnin e9a5b11
graphite-ds: fix unit tests (add jsonData)
alexanderzobnin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
///<reference path="../../../headers/common.d.ts" /> | ||
|
||
import angular from 'angular'; | ||
import _ from 'lodash'; | ||
|
||
export class GraphiteConfigCtrl { | ||
static templateUrl = 'public/app/plugins/datasource/graphite/partials/config.html'; | ||
current: any; | ||
|
||
/** @ngInject */ | ||
constructor($scope) { | ||
this.current.jsonData.graphiteVersion = this.current.jsonData.graphiteVersion || '0.9'; | ||
} | ||
|
||
graphiteVersions = [ | ||
{name: '0.9.x', value: '0.9'}, | ||
{name: '1.0.x', value: '1.0'}, | ||
]; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we additionally check
instanceSettings.jsonData
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed unit tests, but maybe better to check this instead. When I'm loading DS with old settings, seems,
instanceSettings
contains emptyjsonData
anyway. But not sure how it works in previous grafana versions.