case-insensitive LDAP group comparison #9926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bergquist
approved these changes
Nov 21, 2017
bergquist
requested changes
Dec 4, 2017
pkg/login/ldap_user.go
Outdated
| if member == group { | ||
| return true | ||
| } | ||
| return strings.EqualFold(member, group) |
There was a problem hiding this comment.
Not sure this is correct.
If the user is part of two groups it will always return based on the match of the first group. I don't think that's what you want.
There was a problem hiding this comment.
You are right, I'll update the PR.
According to RFC2251 4.1.5, LDAP strings are case-insensitive. Disregard case when comparing group mappings.
|
Hey, can you re-reviews? I believe I've implemented requested changes. |
ryantxu
added a commit
to NatelEnergy/grafana
that referenced
this pull request
May 8, 2018
* grafana/master: Templating : return __empty__ value when all value return nothing to prevent elasticsearch syntaxe error (grafana#9701) http_server: All files in public/build have now a huge max-age (grafana#11536) fix: ldap unit test only error log when err is not nil rename alerting engine to service case-insensitive LDAP group comparison (grafana#9926) changelog: add notes about closing grafana#11813 docs: updated changelog fix XSS vulnerabilities in dashboard links (grafana#11813) PR: ux changes to grafana#11528 decrease length of auth_id column in user_auth table PR comments Make dashboard JSON editable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC2251 4.1.5, LDAP strings are case-insensitive. Disregard case when comparing group mappings.