Switch to dot as resource separator #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjewell
approved these changes
Sep 2, 2021
pkg/grizzly/providers.go
Outdated
Comment on lines
140
to
141
| slashKey := fmt.Sprintf("%s/%s", r.Kind(), UID) | ||
| dotKey := fmt.Sprintf("%s.%s", r.Kind(), UID) |
There was a problem hiding this comment.
I'd be tempted to use the following here, to have less duplication and fewer sources of truth:
Suggested change
| slashKey := fmt.Sprintf("%s/%s", r.Kind(), UID) | |
| dotKey := fmt.Sprintf("%s.%s", r.Kind(), UID) | |
| dotKey := r.Key() // fmt.Sprintf("%s.%s", r.Kind(), UID) | |
| slashKey := fmt.Sprintf("%s/%s", r.Kind(), UID) |
pkg/grizzly/providers.go
Outdated
Comment on lines
58
to
62
| // Key returns a key that combines kind and uid | ||
| func (r *Resource) Key() string { | ||
| uid := r.UID() | ||
| return fmt.Sprintf("%s.%s", r.Kind(), uid) | ||
| } |
There was a problem hiding this comment.
Could be nice to define the .Key method before the .UID() method, so that the file reads from higher-level methods to lower level ones. Similar to the description on this post.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mistakenly assumed that a dot was a special character in globs. It isn't - a single character glob is a question mark.
Therefore, we can revert to using dots as separators everywhere. This PR does that, but it also keeps slash separators working for command line targets.