loki-stack update app version

[renzibin]

hi Abubaker
There is an issue with your pull request: #2875,
https://github.com/grafana/helm-charts/blob/main/charts/loki-stack/requirements.yaml#L5
this line version, the mapping version for Loki is v2.6.1, refer to: https://github.com/grafana/helm-charts/blob/loki-2.15.2/charts/loki/Chart.yaml#L4
Therefore, it is not only necessary to change the outer version, but also to change the mapping version of the loki

Best Regards,
Zibin Ren

[Sheikh-Abubaker]

@renzibin loki v2.9.3 chart version is 5.41.8 here in grafana/loki repo so do I need to append the same in here ??

[renzibin]

I'm not sure if version 5.41.8 works because Loki moved the directory, so after you merge it, I'll try to see if I've replaced Loki's version instead of the old version 2.6.1

[Sheikh-Abubaker]

I'm not sure if version 5.41.8 works because Loki moved the directory, so after you merge it, I'll try to see if I've replaced Loki's version instead of the old version 2.6.1

So what do you suggest? To replace Loki's version with the one that still belongs in the directory ?

However I did change the version to 5.41.8 at first to be able to use loki 2.9.3, but then it throws CI lint error of nil pointer interface {}, and when tried to resolve it threw another CI lint error and loki pods doesn't seem to start, you check my first and last commit in the above PR.

[renzibin]

I'm not sure if my method works, I just hope to solve this problem, Because I use Loki-Stack every day, this version update is very important to me. Loki-Stack is much easier than Loki, Here are my thoughts on this issue:

https://github.com/grafana/helm-charts/blob/main/charts/loki-stack/requirements.yaml#L5
Because this line maps to Loki's version 2.15.2
so
https://github.com/grafana/helm-charts/blob/loki-2.15.2/charts/loki/Chart.yaml#L4
I think this line need to modified to v2.9.3

[Sheikh-Abubaker]

I understand your proposed solution but I doubt that it could become confusing for other users as in artifact hub you can see the loki app version v2.9.3 has chart version v5.41.8, I think maybe we should ask the maintainers for what is needed to be done as of now if they approve of the above changes I would be glad to implement the above.

[Sheikh-Abubaker]

@renzibin As a workaround in your loki-stack values.yaml under loki you can define a image with tag: 2.9.3 as of now while we wait for maintainer's response.

Like this:

image:
    tag: 2.9.3

[renzibin]

@Sheikh-Abubaker
If only the image label of 2.9.3 is replaced, the installed pod: loki will prompt an error and remain in a pending state.
error : Unable to attach or mount volumes: unmounted volumes=[storage], unattached volumes=[tmp config storage rules kube-api-access-ttmww]: timed out waiting for the condition

Moreover, if the chart version is not updated, many configurations in the value. yaml file cannot be updated

[renzibin]

@Sheikh-Abubaker
I want to confirm, has Loki-stack decided not to maintain it? If not maintained, I can only choose to replace loki-stack with loki

[Sheikh-Abubaker]

I want to confirm, has Loki-stack decided not to maintain it? If not maintained, I can only choose to replace loki-stack with loki

@renzibin

loki-stack is deprecated, though it is not documented yet but you can read this discussion, the member of Grafana recommended loki over loki-stack.
https://community.grafana.com/t/difference-between-helm-charts-loki-and-loki-stack/87380/2

[renzibin]

ok, thanks you for reply. I will use loki replace loki-stack, so i close this ticket,

[StefanLobbenmeierObjego]

@renzibin if you find a good migration guide please link it here, I am now also considering moving away from loki-stack

I assume the best solution would be to end up with v3 https://grafana.com/docs/loki/latest/setup/upgrade/upgrade-from-2x/, but not sure if it is possible to do this migration in one step or if it makes sense to first migrate to the non loki-stack v2 and then follow the migration guide to v3

[StefanLobbenmeierObjego]

Just looking at how loki-stack works it seems the best solution is to first replace it with all the charts it has as requirements and then you can follow the normal migration guides for those requirements.

[benharosh]

Can you please add a deprecation note for loki-stack? The above behavior is very confusing (specifying app version v2.9.3 on the chart while actually getting version v2.6.1 from the dependency chart loki-2.15.2 as @renzibin mentioned). On top of all that, you keep bumping versions of loki-stack - so it seems like it's still active and maintained - when there's a clear decision to deprecate it.