Add support for unified alerting queries #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
reviewed
Jun 7, 2022
| @@ -63,6 +65,11 @@ func (s *Server) handlePropertyValueHistoryQuery(ctx context.Context, req *backe | |||
| return DataResponseErrorRequestFailed(err) | |||
| } | |||
|
|
|||
| wide, err := data.LongToWide(frames[0], &data.FillMissing{Mode: data.FillModeNull, Value: math.NaN()}) | |||
There was a problem hiding this comment.
this looks great -- but would love to see the test structure change to show we now return a wide frame
toddtreece
commented
Jun 7, 2022
| // } | ||
| // Name: Demo Turbine Asset 1 | ||
| // Dimensions: 2 Fields by 35 Rows | ||
| // +-------------------------------+--------------------------+ |
There was a problem hiding this comment.
@ryantxu here's an example
toddtreece
changed the title
lean257
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Unified Alerting by switching from long to wide time series frames. Fixes #132
Get property value aggregates:
Get property value history:
Get property value:
I can limit this change to alert queries, but the change also fixes time series rendering in panels and explore.
Before:
After:
