Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statsd / datadog output is too "noisy" #2048

Closed
na-- opened this issue Jun 4, 2021 · 0 comments · Fixed by #2063
Closed

statsd / datadog output is too "noisy" #2048

na-- opened this issue Jun 4, 2021 · 0 comments · Fixed by #2063
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes enhancement evaluation needed proposal needs to be validated or tested before fully implementing it in k6
Milestone
v0.33.0

Comments

@na--
Copy link
Member

na-- commented Jun 4, 2021 •
edited
Loading

By default, we emit a lot of unique metric tags when exporting metrics to StatsD/DataDog. We have the K6_STATSD_TAG_BLOCKLIST option: https://github.com/k6io/k6/blob/da5eebc638d9917cedfe98e232a7eed4cb69a157/output/statsd/config.go#L40

But its value is empty by default... For comparison, we have K6_INFLUXDB_TAGS_AS_FIELDS in the InfluxDB output, and its default value is vu, iter, url: https://github.com/k6io/k6/blob/da5eebc638d9917cedfe98e232a7eed4cb69a157/output/influxdb/config.go#L61

We should probably add the same tags to the default StatsD blocklist value. Users might still have a problem with high cardinality metrics if they don't set the name tag with http.url manually: https://k6.io/docs/using-k6/http-requests/#url-grouping
@na-- na-- added enhancement evaluation needed proposal needs to be validated or tested before fully implementing it in k6 breaking change for PRs that need to be mentioned in the breaking changes section of the release notes labels Jun 4, 2021
@na-- na-- added this to the v0.33.0 milestone Jun 4, 2021
@na-- na-- mentioned this issue Jun 15, 2021
Merged
@kullanici0606 kullanici0606 mentioned this issue Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes enhancement evaluation needed proposal needs to be validated or tested before fully implementing it in k6
Projects
None yet
Milestone
v0.33.0
Development

Successfully merging a pull request may close this issue.

Add vu, iter and url to the default StatsD tag blocklist grafana/k6
1 participant
@na--