Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate js/grpc to ModuleV2 #2343

Closed
codebien opened this issue Jan 18, 2022 · 0 comments · Fixed by #2365
Closed

Migrate js/grpc to ModuleV2 #2343

codebien opened this issue Jan 18, 2022 · 0 comments · Fixed by #2365
Assignees
@codebien
Labels
area: grpc high prio refactor
Milestone
v0.37.0

Comments

@codebien
Copy link
Contributor

Same as we did for the other js modules (e.g #2239), the js grpc client must be migrated to the new modules.Module (aka modules.ModuleV2) API.
@codebien codebien self-assigned this Jan 18, 2022
@codebien codebien added this to the v0.37.0 milestone Jan 18, 2022
@codebien codebien mentioned this issue Jan 18, 2022
Closed
5 tasks
@codebien codebien linked a pull request Feb 3, 2022 that will close this issue
js/grpc: modules.Module migration #2365
Merged
@codebien codebien closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codebien codebien

Labels
area: grpc high prio refactor
Projects
None yet
Milestone
v0.37.0
Development

Successfully merging a pull request may close this issue.

js/grpc: modules.Module migration grafana/k6
1 participant
@codebien