Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bind-time capability to inject kind migrations as Go funcs #29

Open
sdboyer opened this issue Jul 28, 2023 · 0 comments
Open

Add bind-time capability to inject kind migrations as Go funcs #29

sdboyer opened this issue Jul 28, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sdboyer
Copy link
Contributor

sdboyer commented Jul 28, 2023

With grafana/thema#187 merged, we can now add a layer here that wraps that capability for having Go migration funcs, but doesn't expose *thema.Instance in the required func signature. My guess is that the best means for doing it for Core/Custom kinds will be to use our unstructured object type. We can probably skip support for Composable kinds for an initial pass.

As with the thema implementation, i expect we implement this as an option that can be passed to BindCore or BindCustom - a slice of funcs that do the migrations. The thema-based implementation will just pass those down to BindLineage after wrapping them in a dynamic func that just converts to and from the *thema.Instance type.

@sdboyer sdboyer added the enhancement New feature or request label Jul 28, 2023
@sdboyer sdboyer self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant