-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Allow extraObject items as multiline strings #12397
Conversation
I've seen examples of enhancements that bumped the helm chart PATCH version. I bumped the MINOR version because that's what SEMVER dictates, but I'll be happy to change it if you want. |
@JStickler why no more review? I've been waiting on this lately wondering if I shouldn't be updating it? My hesitation is I don't want to do it if it's not going to get attention. |
@TheRealNoob, Michel was getting backed up on other work, removing him as a reviewer just makes it clear to the rest of the team that they should be reviewing this PR. If you could fix the conflicts on this PR, I'll try to get someone from engineering to review for you (I'm the technical writer on the team, so I don't do code reviews, just docs). |
Done. |
@TheRealNoob Thanks for your contribution. This is failing Helm linting. Can you have a look at this? |
@MichelHollands fixed. I found that the bug was introduced in this commit - fortunately it was easy to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
What this PR does / why we need it:
Allows extraObjects to define multiline string passed through
{{ tpl }}
, useful for templating field names.Which issue(s) this PR fixes:
Fixes #12032
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR