Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Allow extraObject items as multiline strings #12397

Merged
merged 12 commits into from
Apr 30, 2024

Conversation

TheRealNoob
Copy link
Contributor

What this PR does / why we need it:

Allows extraObjects to define multiline string passed through {{ tpl }}, useful for templating field names.

Which issue(s) this PR fixes:
Fixes #12032

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@TheRealNoob TheRealNoob requested a review from a team as a code owner March 29, 2024 04:59
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2024

CLA assistant check
All committers have signed the CLA.

@TheRealNoob
Copy link
Contributor Author

I've seen examples of enhancements that bumped the helm chart PATCH version. I bumped the MINOR version because that's what SEMVER dictates, but I'll be happy to change it if you want.

@JStickler JStickler removed the request for review from MichelHollands April 19, 2024 17:27
@TheRealNoob
Copy link
Contributor Author

@JStickler why no more review? I've been waiting on this lately wondering if I shouldn't be updating it? My hesitation is I don't want to do it if it's not going to get attention.

@JStickler JStickler changed the title <helm>: Allow extraObject items as multiline strings feat(helm): Allow extraObject items as multiline strings Apr 22, 2024
@JStickler
Copy link
Contributor

@TheRealNoob, Michel was getting backed up on other work, removing him as a reviewer just makes it clear to the rest of the team that they should be reviewing this PR. If you could fix the conflicts on this PR, I'll try to get someone from engineering to review for you (I'm the technical writer on the team, so I don't do code reviews, just docs).

@TheRealNoob
Copy link
Contributor Author

If you could fix the conflicts on this PR, I'll try to get someone from engineering to review for you

Done.

@MichelHollands
Copy link
Contributor

@TheRealNoob Thanks for your contribution. This is failing Helm linting. Can you have a look at this?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 30, 2024
@TheRealNoob
Copy link
Contributor Author

@MichelHollands fixed. I found that the bug was introduced in this commit - fortunately it was easy to fix.

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichelHollands MichelHollands merged commit af5be90 into grafana:main Apr 30, 2024
61 checks passed
shantanualsi pushed a commit that referenced this pull request May 6, 2024
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
@hervenicol hervenicol mentioned this pull request Jun 3, 2024
7 tasks
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[helm] ingress-secret isn't idempotent
4 participants