feat: Enable log volume endpoint by default in helm #12690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
benclive
reviewed
Apr 19, 2024
production/helm/loki/values.yaml
Outdated
| @@ -1906,7 +1907,8 @@ distributor: | |||
| # -- Node selector for distributor pods | |||
| nodeSelector: {} | |||
| # -- Tolerations for distributor pods | |||
| tolerations: [] | |||
| tolerations: | |||
There was a problem hiding this comment.
Is this formatting change intentional? Putting the value on a new line is used inconsistently across this file (see nodeSelector above). It would probably make sense to do it one way or the other. Or just leave these lines untouched :)
This was referenced Apr 22, 2024
This was referenced May 6, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Set volume API on by default in helm this is going to be a better experience and has been there for a while.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR