-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Querier: Split gRPC client into two. #12726
Conversation
I think maybe a different approach here would be to introduce two new sections
And then leave the current section as is and have it populate both of these values. This allows us to not have to use a boolean value to decide which to use, instead we should add validation to the validate function in loki.go that errors if you specify We can also decide too if we want to deprecate WDYT? |
Ok I pushed a commit doing something similar:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you Dylan :)
docs/sources/shared/configuration.md
Outdated
@@ -5329,83 +5328,83 @@ The `swift_storage_config` block configures the connection to OpenStack Object S | |||
|
|||
```yaml | |||
# OpenStack Swift authentication API version. 0 to autodetect. | |||
# CLI flag: -<prefix>.swift.auth-version | |||
# CLI flag: -swift.auth-version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these shouldn't be here.
@@ -543,19 +543,19 @@ The `alibabacloud_storage_config` block configures the connection to Alibaba Clo | |||
|
|||
```yaml | |||
# Name of OSS bucket. | |||
# CLI flag: -common.storage.oss.bucketname |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this flag docs was bugged this whole time
What this PR does / why we need it:
Split the gRPC client used by the querier into two, one for the communication with the scheduler, the other for communicating with the query-frontend.
query_scheduler_grpc_client
config or the new CLI flagquerier.scheduler-grpc-client
query_frontend_grpc_client
instead of the oldgrpc_client_config
. Just make sure you don't use both at the same time, it will result in an error.This work is necessary for configuring custom behavior between
querier<->scheduler
vsquerier<->frontend
. A use case is configuring mTLS when a different certificate is used by queriers, schedulers and frontends. You can only configure a singleserver_name
with our current setup, making it impossible.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR