-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing Helm helper loki.hpa.apiVersion #12755
Merged
MichelHollands
merged 11 commits into
grafana:main
from
mattgialelis:FixHorizontalPodAutoscalerHelmHepler
Apr 30, 2024
Merged
fix: Add missing Helm helper loki.hpa.apiVersion #12755
MichelHollands
merged 11 commits into
grafana:main
from
mattgialelis:FixHorizontalPodAutoscalerHelmHepler
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Any update on how i can get this merged in ? Is sadly stopping me from moving to loki 3.0 and away from the loki-distributed helm chart |
@JStickler Any ideas on the process to get his merged in please :) |
MichelHollands
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
shantanualsi
pushed a commit
that referenced
this pull request
May 6, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
This was referenced May 6, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently the 6.3.3 and 6.2.2. helm charts when trying to enable the Horizontal Pod Autoscaler for the Distributed deployment type fails due to the missing loki.hpa.apiVersion which is required for the the Helm chart to template/install making it un-useable for large scale deployments with the need for autoscaling
Error that is fixed by this PR
Error:
Which issue(s) this PR fixes:
Fixes #12716
Special notes for your reviewer:
Had to recreate this pr, the rebase i did on my fork broke the last branch and PR, sry
Checklist
CONTRIBUTING.md
guide (required)docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR