feat(blooms): ignore individual bloom-gw failures #12863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
owen-d
commented
May 2, 2024
owen-d
commented
- includes a new metric to record statuses now that we ignore errors
- Also removes old/no longer relevant cache locality score metric since we now resolve bloom-gw membership in a different way
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
chaudum
reviewed
May 2, 2024
pkg/bloomgateway/client.go
Outdated
| "blocks", len(rs.blocks), | ||
| "err", err, | ||
| ) | ||
| return nil |
There was a problem hiding this comment.
In case a request fails, the results entries need to be equal to the request entries, otherwise we assume that all requested chunks have been filtered out.
Suggested change
| return nil | |
| results[i] = rs.groups | |
| count += len(rs.groups) | |
| return nil |
There was a problem hiding this comment.
Increasing count is not strictly needed, but the value is used for the allocation of the result buffer.
| Buckets: prometheus.LinearBuckets(0.01, 0.2, 5), | ||
| }), | ||
| Name: "requests_total", | ||
| Help: "Total number of requests made to the bloom gateway", |
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
chaudum
approved these changes
May 2, 2024
pkg/bloomgateway/client.go
Outdated
| "blocks", len(rs.blocks), | ||
| "err", err, | ||
| ) | ||
| return nil |
There was a problem hiding this comment.
Increasing count is not strictly needed, but the value is used for the allocation of the result buffer.
pkg/bloomgateway/client_test.go
Outdated
| @@ -52,7 +52,7 @@ func TestGatewayClient_MergeSeries(t *testing.T) { | |||
| {Fingerprint: 0x01, Refs: []*logproto.ShortRef{shortRef(0, 1, 3), shortRef(1, 2, 4)}}, // fully overlapping chunks | |||
| {Fingerprint: 0x02, Refs: []*logproto.ShortRef{shortRef(0, 1, 5), shortRef(1, 2, 6)}}, // partially overlapping chunks | |||
| }, | |||
| // response 2 | |||
| // response 3 | |||
…in all cases Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
chaudum
approved these changes
May 2, 2024
shantanualsi
pushed a commit
that referenced
this pull request
May 6, 2024
grafanabot
pushed a commit
that referenced
this pull request
May 6, 2024
(cherry picked from commit 4c9b22f)
chaudum
pushed a commit
that referenced
this pull request
May 6, 2024
This was referenced May 13, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.