Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panics when ingester response is nil #12946

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented May 13, 2024

What this PR does / why we need it:

This PR fixes panics when ingester response is nil

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@shantanualsi shantanualsi changed the title Fix panics when ingester response is nil dix: panics when ingester response is nil May 13, 2024
@shantanualsi shantanualsi changed the title dix: panics when ingester response is nil fix: panics when ingester response is nil May 13, 2024
@shantanualsi shantanualsi marked this pull request as ready for review May 13, 2024 07:49
@shantanualsi shantanualsi requested a review from a team as a code owner May 13, 2024 07:49
Copy link
Contributor

@benclive benclive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why the ingester responses could be nil? This seems to fix the panics but I'm curious how we're getting nil responses in the first place

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shantanualsi
Copy link
Contributor Author

Do we know why the ingester responses could be nil?
@benclive my guess is because the time range is older than query_ingesters_within (which is default 3h).. In this case, the ingesters do not have any labels..

@cyriltovena cyriltovena merged commit 3cc28aa into main May 13, 2024
59 checks passed
@cyriltovena cyriltovena deleted the fix-querier-panics branch May 13, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants