Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blooms): Add counter metric for blocks that are not available at query time #12968

Merged
merged 2 commits into from
May 28, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented May 15, 2024

What this PR does / why we need it:

When filtering chunks on the bloom gateway, bloom block may not be available and they will be downloaded asynchronously in the background.

This new metric loki_bloom_gateway_blocks_not_available_total counts the blocks that are not available at query time.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum chaudum requested a review from a team as a code owner May 15, 2024 06:42
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Total amount of blocks that have been skipped because they were not
found or not downloaded yet.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/filter-ratio-metrics branch from 0a715a0 to 7af0811 Compare May 28, 2024 18:04
@chaudum chaudum enabled auto-merge (squash) May 28, 2024 18:04
@chaudum chaudum merged commit d6374bc into main May 28, 2024
59 checks passed
@chaudum chaudum deleted the chaudum/filter-ratio-metrics branch May 28, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants