Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Track bytes discarded by ingester. #12981

Merged
merged 4 commits into from
May 16, 2024

Conversation

jeschkies
Copy link
Contributor

@jeschkies jeschkies commented May 16, 2024

What this PR does / why we need it:
Only the distributor was tracking discarded bytes. The ingester was missing the tracker and calls.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jeschkies jeschkies changed the title Track bytes discarded by ingester. fix: Track bytes discarded by ingester. May 16, 2024
@jeschkies jeschkies marked this pull request as ready for review May 16, 2024 15:21
@jeschkies jeschkies requested a review from a team as a code owner May 16, 2024 15:21
@jeschkies jeschkies enabled auto-merge (squash) May 16, 2024 15:32
@jeschkies jeschkies merged commit 88c6711 into grafana:main May 16, 2024
58 checks passed
@jeschkies jeschkies deleted the karsten/usage-tracker-ingester branch May 16, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants