-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): fix query-frontend and ruler targetPort 'http-metrics' in Service template #13024
fix(helm): fix query-frontend and ruler targetPort 'http-metrics' in Service template #13024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also fix the ruler and QF?
f349444
to
f4f2f31
Compare
Done |
f4f2f31
to
e693d59
Compare
thanks, this is fantastic ❤️
|
could you trigger a recheck by visiting https://cla-assistant.io/check/grafana/loki?pullRequest=13024? |
I did many times but it does not work. |
A fix seems to be merged for the same issue now apparently when trying to resolve conflicts with main branch. |
@archimeid a colleague just pointed out the fact that there are commits from this other account @vpo-cdc, it needs to have a CLA approval from him too |
e693d59
to
7716d84
Compare
OMG, you're totally right. I have edited my commit. It was another user I am using at work. |
What this PR does / why we need it:
This PR is a fix for Loki Helm Chart.
The templates for query-frontend-headless Service and ruler Service have an issue on "targetPort".
This issue is the same as the one detected for query-scheduler in version 6.6.1.
targetPort
is currentlyhttp
but the port name in Deployment (or StatefulSet) template ishttp-metrics
.Template for query-frontend deployment
Template for ruler stateful-set
Thus, those Services have no endpoint available for the
http-metrics
port because of the mismatch.Setting targetPort to
http-metrics
has solved the issue.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR