Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push official images to a different registry, in addition to Docker Hub #4143

Open
onedr0p opened this issue Aug 11, 2021 · 14 comments
Open
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@onedr0p
Copy link

onedr0p commented Aug 11, 2021

Is your feature request related to a problem? Please describe.

Dockerhub rate limits

Describe the solution you'd like

Push loki and promtail to an additional registry like Quay or GHCR

Additional context

grafana/grafana#27677

@cgill27
Copy link

cgill27 commented Aug 15, 2021

Google has a pull through caching mirror of dockerhub, use it instead of dockerhub when trying to get around dockerhub rate limits (if not paying for dockerhub account): mirror.gcr.io

@onedr0p
Copy link
Author

onedr0p commented Aug 15, 2021

@cgill27 that doesn't seem to work, it only supports "special" dockerhub images. What "special" means is unclear but maybe only :latest tags.

✖ docker pull mirror.gcr.io/grafana/loki:2.3.0
Error response from daemon: manifest for mirror.gcr.io/grafana/loki:2.3.0 not found: manifest unknown: Failed to fetch "2.3.0" from request "/v2/grafana/loki/manifests/2.3.0".
...
✖ docker pull mirror.gcr.io/grafana/loki:latest
latest: Pulling from grafana/loki
540db60ca938: Pull complete
65d480ecda58: Pull complete
d4b0fb325642: Pull complete
f29bcac4b7d0: Pull complete
24c6616bac1a: Pull complete
f4d1f2c1c39d: Pull complete
947a9928c44d: Pull complete
Digest: sha256:00bdfb87a62b16e91346aeca656538764a5110214e7ce904e833872ffba184c4
Status: Downloaded newer image for mirror.gcr.io/grafana/loki:latest
mirror.gcr.io/grafana/loki:latest

@Nemric
Copy link

Nemric commented Sep 1, 2021

I had this problem for all of my promtail instances and updates
I've created a docker.io/registry container that act as a proxy registry for all my docker hub images, it works great !

@stale
Copy link

stale bot commented Oct 2, 2021

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Oct 2, 2021
@onedr0p
Copy link
Author

onedr0p commented Oct 2, 2021

Still interested in this becoming a reality, thanks!

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Oct 2, 2021
@stale
Copy link

stale bot commented Mar 3, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Mar 3, 2022
@onedr0p
Copy link
Author

onedr0p commented Mar 3, 2022

Not stale

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Mar 3, 2022
@jeschkies jeschkies added the keepalive An issue or PR that will be kept alive and never marked as stale. label Mar 3, 2022
@MatteoJoliveau
Copy link

Definitely an issue for us as well, especially when running on AWS spot instances (which get frequently rotated, causing re-pulling). GitHub has a free container registry that is available automatically on all public repositories, it should be easy to integrate in your CI workflow.

@onedr0p
Copy link
Author

onedr0p commented Mar 15, 2023

Given the recent dockerhub announcement of removing free team orgs, I'm wondering if the current grafana org will be affected? And if so perhaps this could finally have a high priority?

docker/hub-feedback#2314

@remram44
Copy link

It looks like the grafana account is a "verified publisher", which should make it exempt from rate limits.

@danieljkemp
Copy link

It looks like the grafana account is a "verified publisher", which should make it exempt from rate limits.

Removal of rate limiting for developers

Do the rate limits not apply for downloads of the images, or does the wording imply that developers of the verified publisher's org are not subject to rate limits?

@remram44
Copy link

Anyone can download from verified publishers without limit.

For some reason that doesn't apply to "official images", only images from "verified publishers". It's weird but seems reliable for now.

@stdmje
Copy link

stdmje commented Sep 20, 2024

Any news on this?

@MartinEmrich
Copy link

Even if, the Loki helm chart uses 3rd-party software too.

failed to pull and unpack image "docker.io/library/memcached:1.6.23-alpine"

(Similar: grafana/helm-charts#1400)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Development

No branches or pull requests

9 participants