Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOUCH_PROTOS build arg for dockerfile #1479

Merged
merged 4 commits into from
Jan 8, 2020
Merged

TOUCH_PROTOS build arg for dockerfile #1479

merged 4 commits into from
Jan 8, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 7, 2020

This allows us an escape hatch to avoid recompiling protos when building a docker image. Use with care!

closes #1477

@owen-d owen-d requested a review from slim-bean January 7, 2020 22:25
cyriltovena
cyriltovena approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@cyriltovena cyriltovena merged commit 29e4ad8 into grafana:master Jan 8, 2020
@pracucci pracucci mentioned this pull request Jan 9, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@slim-bean slim-bean Awaiting requested review from slim-bean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ARM flaky build.
2 participants
@owen-d @cyriltovena