Fixed TOUCH_PROTOS in all DroneCI pipelines #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
the drone.yml is auto generated from the drone.jsonnet file using the |
owen-d
approved these changes
Jan 9, 2020
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Thanks @slim-bean for letting me know (I wasn't aware of it). I should have fixed it. Let's see if the Drone builds pass. |
|
@slim-bean The Ci passed. Do you have any other feedback, before merging it? |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR #1479 introduced
TOUCH_PROTOSto avoid protos to be rebuilt on arm64 only, while we should do it for all DroneCI pipelines (amd64 and arm).Which issue(s) this PR fixes:
Fixes #1477
Checklist