Limit series for metric queries. #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
requested review from
achatterjee-grafana and
oddlittlebird
as code owners
cyriltovena
commented
Nov 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #2903 +/- ##
==========================================
+ Coverage 61.58% 61.74% +0.15%
==========================================
Files 181 182 +1
Lines 14714 14759 +45
==========================================
+ Hits 9062 9113 +51
+ Misses 4824 4814 -10
- Partials 828 832 +4
|
cyriltovena
commented
Nov 9, 2020
achatterjee-grafana
approved these changes
Nov 9, 2020
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…afana#2903) * remove global metrics registry and util.Logger in cache package Signed-off-by: Ben Ye <yb532204897@gmail.com> * address comments and update changelog Signed-off-by: Ben Ye <yb532204897@gmail.com> * use util.Logger instead of noop logger Signed-off-by: Ben Ye <yb532204897@gmail.com> * use nil prometheus registry and address some nits Signed-off-by: Ben Ye <yb532204897@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new limits: max series returned for metric queries. When a query exceed the maximum of series a 400 will be returned.
It will fail fast, on the first step of the engine (querier) evaluation or the first split of the query-frontend that cross the threshold.
Fixes #2823