Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits metrics queries cardinality. #2823

Closed
cyriltovena opened this issue Oct 27, 2020 · 2 comments · Fixed by #2903
Closed

Limits metrics queries cardinality. #2823

cyriltovena opened this issue Oct 27, 2020 · 2 comments · Fixed by #2903
Assignees
Milestone

Comments

@cyriltovena
Copy link
Contributor

With the new LogQL extensions we can now implicitly extract many labels.

Specially with logfmt and json.

We should add a way to via configuration:

  • limit the maximum amount of labels per unique series and unique total series.

Questions ?

  • Where should this be checked, within ingesters ? queriers ? frontend ? all of them ?
@cyriltovena cyriltovena added this to the 2.1 milestone Oct 27, 2020
@owen-d
Copy link
Member

owen-d commented Oct 27, 2020

I think you have to check them wherever we run parsers because the label set is only available after parsing.

I also think it'd be helpful to be able to specify a strategy at the query level such that you can either error the whole query or drop any offending lines (similar to using __error__ in logql). WDYT?

@cyriltovena cyriltovena self-assigned this Nov 4, 2020
@cyriltovena
Copy link
Contributor Author

I will start with errors for now, no dropping, we can do that later since I think it's more complex to craft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants