Documentation fix for downstream_url #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3109 +/- ##
==========================================
+ Coverage 62.80% 62.85% +0.04%
==========================================
Files 186 186
Lines 15949 15949
==========================================
+ Hits 10017 10024 +7
+ Misses 5002 4997 -5
+ Partials 930 928 -2
|
sandeepsukhani
approved these changes
Jan 4, 2021
| @@ -60,7 +60,7 @@ data: | |||
|
|
|||
| frontend: | |||
| log_queries_longer_than: 5s | |||
| downstream_url: querier.<namespace>.svc.cluster.local:3100 | |||
| downstream_url: http://querier.<namespace>.svc.cluster.local:3100 | |||
There was a problem hiding this comment.
Not that its a problem setting a scheme explicitly here but I wonder if you are facing any issue without setting the it. We do not face any issue when it is not set.
There was a problem hiding this comment.
Yes, I just tested it. Without http://, it gives the following error regarding unsupported protocol scheme
level=warn ts=2021-01-04T14:37:38.35781553Z caller=logging.go:62 traceID=8c074c80cfcc1a msg="GET /ready (500) 156.572µs Response: \"unsupported protocol scheme \\\"loki.service.dc.consul\\\"\\n\"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Documentation of downstream_url is outdated as it references Prometheus instead of Loki, this PR updates it. downstream_url needs to contain the protocol (http://) where-in the example incorrectly mentions only the hostname and port; which is fixed in this PR.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist