Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation fix for downstream_url #3109

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Documentation fix for downstream_url #3109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2238cb1
Merge pull request #1 from grafana/master
nileshcs Jan 3, 2021
fd919b6
Update docs for downstream_url
n-saw Jan 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/sources/configuration/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ The query_frontend_config configures the Loki query-frontend.
# CLI flag: -querier.compress-http-responses
[compress_responses: <boolean> | default = false]

# URL of downstream Prometheus.
# URL of downstream Loki.
# CLI flag: -frontend.downstream-url
[downstream_url: <string> | default = ""]

Expand Down
2 changes: 1 addition & 1 deletion docs/sources/configuration/query-frontend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ data:

frontend:
log_queries_longer_than: 5s
downstream_url: querier.<namespace>.svc.cluster.local:3100
downstream_url: http://querier.<namespace>.svc.cluster.local:3100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that its a problem setting a scheme explicitly here but I wonder if you are facing any issue without setting the it. We do not face any issue when it is not set.

Copy link
Author

@n-saw n-saw Jan 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just tested it. Without http://, it gives the following error regarding unsupported protocol scheme

level=warn ts=2021-01-04T14:37:38.35781553Z caller=logging.go:62 traceID=8c074c80cfcc1a msg="GET /ready (500) 156.572µs Response: \"unsupported protocol scheme \\\"loki.service.dc.consul\\\"\\n\"

compress_responses: true
```

Expand Down