[loki-distributed] Fix compactor address without protocol schema #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Amen to that. |
zaldnoay
force-pushed
the
fix_loki_compactor_address
branch
3 times, most recently
from
3c03203
to
d0e960f
Compare
|
Hey guys, it's a small tweak, can we get this merged? 🙏 |
|
Please update Chart.yaml |
zaldnoay
force-pushed
the
fix_loki_compactor_address
branch
from
d0e960f
to
6e643d8
Compare
Signed-off-by: junwei.liang <junwei.liang@mintegral.com> Signed-off-by: junwei.liang <zaldnoay@users.noreply.github.com>
Signed-off-by: junwei.liang <zaldnoay@users.noreply.github.com>
zaldnoay
force-pushed
the
fix_loki_compactor_address
branch
from
6e643d8
to
3fa3418
Compare
|
@patsevanton |
|
@zanhsieh Could you merge request please ? |
zanhsieh
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of loki included a wrong compactor address, which caused the following errors from other components:
This changes fix compactor address by adding
http://protocol schema.Related comment: grafana/loki#3109 (comment)
Signed-off-by: junwei.liang junwei.liang@mintegral.com