New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass custom Prometheus registerer to promtail #3174

Closed

rfratto opened this issue Jan 14, 2021 · 0 comments · Fixed by #3175

Member

rfratto commented Jan 14, 2021

Currently, all of the metrics in Promtail are registered to the global Prometheus registerer. This causes a problem in the Grafana Cloud Agent:

Promtail metrics are already registered, even if you're not using the embedded Promtail
You can only have one set of metrics globally, i.e., if you wanted multiple embedded Promtails, they would share a global set of metrics.

I would like to pass around a registry and register metrics at the time of instantiation rather than having them be globals.

This is a change I will implement myself in a few days, but wanted to open an issue first in case this would be contentious.

rfratto mentioned this issue

Promtail: pass a prometheus registerer to promtail components #3175

Merged

owen-d closed this as completed in #3175

rfratto mentioned this issue

promtail: pass registerer to gcplog #3191

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment