Bump prometheus dependency #6403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had to add a replace of prometheus in go mod because thanos is importing an older version and then replacing it.
WithoutLabels and WithLabels methods have dissappeared. Now labels.NewBuilder has to be used.
Update now accepts a new param called ruleGroupPostProcessFunc which is an optional function to be executed after rule group processing. In this case I've set it to nil in the usages i've found.
The NewQueryRange function now accepts QueryOptions so I had to update all the calls. I've set the opts to nil since we're not using them.
jesusvazquez
force-pushed
the
jvp/update-prometheus
branch
from
2a23034
to
ccdcc02
Compare
pstibrany
approved these changes
Jun 15, 2022
| HTTPClientConfig: promConfig.HTTPClientConfig{ | ||
| FollowRedirects: true, | ||
| }, | ||
| HTTPClientConfig: promConfig.DefaultHTTPClientConfig, |
There was a problem hiding this comment.
HTTP2Enabled now defaults to true, should this be documented as a [CHANGE]?
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
owen-d
approved these changes
Jun 15, 2022
|
Unfortunately this bump breaks GEL as it depends on an older Prometheus version through backend-enterprise-libs :/ |
4 tasks
dannykopping
pushed a commit
to dannykopping/loki
that referenced
this pull request
Aug 23, 2022
These metrics were removed unintentionally in grafana#6403 Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
pushed a commit
that referenced
this pull request
Aug 23, 2022
….*` metrics (#6957) * Upgrading prometheus/client_golang to restore go_sched.* metrics These metrics were removed unintentionally in #6403 Signed-off-by: Danny Kopping <danny.kopping@grafana.com> * Fixing test to match interface correctly Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
pushed a commit
that referenced
this pull request
Aug 23, 2022
….*` metrics (#6957) * Upgrading prometheus/client_golang to restore go_sched.* metrics These metrics were removed unintentionally in #6403 Signed-off-by: Danny Kopping <danny.kopping@grafana.com> * Fixing test to match interface correctly Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
….*` metrics (grafana#6957) * Upgrading prometheus/client_golang to restore go_sched.* metrics These metrics were removed unintentionally in grafana#6403 Signed-off-by: Danny Kopping <danny.kopping@grafana.com> * Fixing test to match interface correctly Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates prometheus dependency to its latest commit. It comes with quite a few changes so I've made a list of commits that make it easy to review them.