Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mimir-continuous-test]: Support authentication #2105

Closed
Logiraptor opened this issue Jun 14, 2022 · 0 comments · Fixed by #2717
Closed

[mimir-continuous-test]: Support authentication #2105

Logiraptor opened this issue Jun 14, 2022 · 0 comments · Fixed by #2717
Labels
component/continuous-test mimir-continuous-test related work

Comments

@Logiraptor
Copy link
Contributor

Is your feature request related to a problem? Please describe.

mimir-continuous-test currently supports using a tenant ID only. It would be nice to support Basic Authentication and Bearer token authentication. These are both supported in Grafana Enterprise Metrics, so they would be a necessary step to run continuous testing against a GEM cluster in certain configurations. It would also be useful for any users who have configured any other authenticating gateway in front of OSS Grafana Mimir.

Describe the solution you'd like

Add three additional flags:

-basic-auth-username
-basic-auth-password
-bearer-token

These would be used in the continuoustest Client struct to perform the various HTTP requests similar to how tenant-id works today.

Describe alternatives you've considered

We could alternatively only support deploying mimir-continuous-test behind the authentication layer, but this is limiting especially in highly regulated deployments.

Additional context

This feature would enable customers with enterprise auth enabled in a Grafana Enterprise Metrics cluster to use the helm test command as a smoke test. Currently this is only possible if you have auth.type set to trust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/continuous-test mimir-continuous-test related work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant