Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mimir documentation about out-of-order #2183

Merged
merged 12 commits into from
Jun 27, 2022
Merged

Mimir documentation about out-of-order #2183

merged 12 commits into from
Jun 27, 2022

Conversation

jesusvazquez
Copy link
Member

@jesusvazquez jesusvazquez commented Jun 22, 2022 •
edited

Out of order support is coming as an experimental feature.

This PR is suggesting some new files about it. It is the first time that I add new documentation to Mimir so please let me know about any suggestions or things you would change to make it clear.

@jesusvazquez
Mimir documentation about out-of-order
ee832e4 
Out of order support is coming as an experimental feature in Mimir
2.2.0. This commit adds the main documentation files about the feature.
@jesusvazquez jesusvazquez added the type/docs Improvements or additions to documentation label Jun 22, 2022
@jesusvazquez jesusvazquez self-assigned this Jun 22, 2022
codesome
codesome reviewed Jun 23, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@codesome codesome mentioned this pull request Jun 23, 2022
Merged
3 tasks
pstibrany
pstibrany reviewed Jun 23, 2022
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending initial comments, despite PR being a draft (haven't realized until I've found "TDB" comment.)

docs/sources/operators-guide/architecture/components/ingester.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
@jesusvazquez jesusvazquez force-pushed the jvp/out-of-order-documentation branch from 97ca7f3 to bc4c839 Compare June 24, 2022 08:08
@jesusvazquez jesusvazquez marked this pull request as ready for review June 24, 2022 08:26
osg-grafana
osg-grafana approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@osg-grafana osg-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking with feedback

@jesusvazquez @osg-grafana
Address Ursula's feedback
2f6b386 
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
@jesusvazquez jesusvazquez force-pushed the jvp/out-of-order-documentation branch from 5ef48a8 to 2f6b386 Compare June 24, 2022 09:41
pstibrany
pstibrany reviewed Jun 24, 2022
View reviewed changes
docs/sources/operators-guide/architecture/components/ingester.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/architecture/components/ingester.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/configuring/configuring-out-of-order-samples-ingestion.md Outdated Show resolved Hide resolved
@jesusvazquez jesusvazquez force-pushed the jvp/out-of-order-documentation branch from c200da5 to 397a44d Compare June 24, 2022 10:34
@jesusvazquez @pstibrany
Address Peter's suggestions
88304a9 
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
@jesusvazquez jesusvazquez force-pushed the jvp/out-of-order-documentation branch from 397a44d to 88304a9 Compare June 24, 2022 10:36
@pstibrany pstibrany mentioned this pull request Jun 27, 2022
Merged
jesusvazquez and others added 2 commits June 27, 2022 12:50
@jesusvazquez
Remove prettier wraps
7c45eb2
@jesusvazquez @pstibrany @pracucci
Apply suggestions from code review
5209a4e 
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
@jesusvazquez jesusvazquez force-pushed the jvp/out-of-order-documentation branch from 785dbfc to 5209a4e Compare June 27, 2022 10:54
@colega colega mentioned this pull request Jun 27, 2022
Closed
7 tasks
replay
replay approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jesusvazquez @replay
Mauro's suggestion
f050259 
Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay replay merged commit 5a0bbd6 into main Jun 27, 2022
@replay replay deleted the jvp/out-of-order-documentation branch June 27, 2022 18:43
rlex added a commit to rlex/mimir that referenced this pull request Jun 28, 2022
@rlex
Merge branch 'main' into helm_prometheusrule
208d9c8 
* main: (63 commits)
  Add new section on website for links to blog posts, podcasts and talks. (grafana#2216)
  Rename codified errors to errors catalog (grafana#2256)
  Helm: add a step to contributing doc (grafana#2257)
  Signal that 2.2 release is now in progress. (grafana#2254)
  Removed migration of alertmanager local state files from old hierarchy (Cortex 1.8 and earlier) (grafana#2253)
  operations/mimir: Change multi_zone_ingester_max_unavailable to 25 (grafana#2251)
  Helm: weekly release (grafana#2252)
  Jsonnet: Configure ingester max global metadata per user and per metric (grafana#2250)
  Helm: metamonitor naming (grafana#2236)
  Mimir documentation about out-of-order (grafana#2183)
  Vendor latest mimir-prometheus/main (grafana#2243)
  Set CODEOWNERS to primary technical writer (grafana#2242)
  Use BasicLifecycler for distributors and auto-forget (grafana#2154)
  Docs: Basic documentation for deploying the ruler using jsonnet. (grafana#2127)
  Fix post merge reviews on 2187 (grafana#2230)
  Add tests for user metadata in the ingester (grafana#2184)
  Change the error message template for per-tenant limits (grafana#2234)
  helm: meta-monitoring (grafana#2068)
  Article about migrating from Consul to memberlist. Added documentation for /memberlist endpoint. (grafana#2166)
  Update runbooks to mention possibility to investigate memberlist KV store in various alerts (grafana#2158)
  ...
masonmei pushed a commit to udmire/mimir that referenced this pull request Jul 11, 2022
@jesusvazquez @osg-grafana
@pstibrany @pracucci @replay
Mimir documentation about out-of-order (grafana#2183)
e612d7b 
* Mimir documentation about out-of-order

Out of order support is coming as an experimental feature in Mimir
2.2.0. This commit adds the main documentation files about the feature.

* Remove ingester entry from CHANGELOG

* Accept suggestion

* Address suggestions and fill the configuration

* Address Ursula's feedback

Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>

* Update ingester WBL doc

* Address Peter's suggestions

Co-authored-by: Peter Štibraný <pstibrany@gmail.com>

* Remove prettier wraps

* Apply suggestions from code review

Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>

* Add clarification note

* Other suggestions

* Mauro's suggestion

Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>

Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@replay replay replay approved these changes

@pstibrany pstibrany pstibrany approved these changes

@pracucci pracucci pracucci left review comments

@codesome codesome codesome left review comments

@osg-grafana osg-grafana osg-grafana approved these changes

Assignees

@jesusvazquez jesusvazquez

Labels
type/docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jesusvazquez @replay @pstibrany @pracucci @codesome @osg-grafana