Helm: metamonitor naming #2236
Merged
Helm: metamonitor naming #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
In values.yaml, move serviceMonitor to metaMonitoring.serviceMonitor. The reason is to group everything related to metaMonitoring and also avoid the impression that this serviceMonitor is somehow processed by Mimir. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/20220625-metamonitor-naming
branch
from
0ef49f1
to
341973a
Compare
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
ortuman
approved these changes
Jun 28, 2022
rlex
added a commit
to rlex/mimir
that referenced
this pull request
Jun 28, 2022
* main: (63 commits) Add new section on website for links to blog posts, podcasts and talks. (grafana#2216) Rename codified errors to errors catalog (grafana#2256) Helm: add a step to contributing doc (grafana#2257) Signal that 2.2 release is now in progress. (grafana#2254) Removed migration of alertmanager local state files from old hierarchy (Cortex 1.8 and earlier) (grafana#2253) operations/mimir: Change multi_zone_ingester_max_unavailable to 25 (grafana#2251) Helm: weekly release (grafana#2252) Jsonnet: Configure ingester max global metadata per user and per metric (grafana#2250) Helm: metamonitor naming (grafana#2236) Mimir documentation about out-of-order (grafana#2183) Vendor latest mimir-prometheus/main (grafana#2243) Set CODEOWNERS to primary technical writer (grafana#2242) Use BasicLifecycler for distributors and auto-forget (grafana#2154) Docs: Basic documentation for deploying the ruler using jsonnet. (grafana#2127) Fix post merge reviews on 2187 (grafana#2230) Add tests for user metadata in the ingester (grafana#2184) Change the error message template for per-tenant limits (grafana#2234) helm: meta-monitoring (grafana#2068) Article about migrating from Consul to memberlist. Added documentation for /memberlist endpoint. (grafana#2166) Update runbooks to mention possibility to investigate memberlist KV store in various alerts (grafana#2158) ...
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
* Helm: Move serviceMonitor to metaMonitoring In values.yaml, move serviceMonitor to metaMonitoring.serviceMonitor. The reason is to group everything related to metaMonitoring and also avoid the impression that this serviceMonitor is somehow processed by Mimir. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In values.yaml, move serviceMonitor to metaMonitoring.serviceMonitor
The reason is that some people confuse serviceMonitor with something they can use to set up Mimir like Prometheus operator.
Also there are more resources like serviceMonitor are incoming, and the root namespace of values.yaml would get crowded.
Which issue(s) this PR fixes or relates to
Related to: #2014 , #2134
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]