Use default HTTP and gRPC ports in the read-write local dev env #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
changed the base branch from
main
to
add-alertmanager-support-to-backend-target
Base automatically changed from
add-alertmanager-support-to-backend-target
to
main
August 26, 2022 07:47
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
use-same-port-in-read-write-dev-env
branch
from
33fdcd9
to
086f701
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When working on #2838 I've found annoying that each replica in the local dev env customize the HTTP and gRPC port. We don't really need it, we just need the published port to be different.
In this PR I'm using the default HTTP (8080) and gRPC (9095) ports, and then using a different port for each replica when publishing them to the host (keeps the previous published port number).
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]