Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ingester to query native histograms #4512

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

krajorama
Copy link
Contributor

@krajorama krajorama commented Mar 16, 2023

What this PR does

Update chunkcompat/compat.go to be able to decode ingester reply in unit tests correctly.
Add an integration test for ingestion.

Which issue(s) this PR fixes or relates to

Related to: #3478

Checklist

  • Tests updated
  • N/A Documentation added
  • N/A CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
    Next PR to enable query sharding as well and update the changelog

Update chunkcompat/compat.go to be able to decode ingester reply in
unit tests correctly.
Add an integration test for ingestion.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
pkg/ingester/ingester_test.go Outdated Show resolved Hide resolved
pkg/ingester/ingester_test.go Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Show resolved Hide resolved
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have a few nitpicks

pkg/ingester/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
integration/ingester_test.go Outdated Show resolved Hide resolved
krajorama and others added 2 commits March 16, 2023 16:41
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama enabled auto-merge (squash) March 16, 2023 15:49
@krajorama krajorama merged commit b125392 into main Mar 16, 2023
@krajorama krajorama deleted the krajo/from-sparsehistogram branch March 16, 2023 16:02
krajorama added a commit that referenced this pull request Mar 16, 2023
Ref: #4512

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants