Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jaeger Trace visualization with Flamegraph #1170

Closed
3 tasks done
Rperry2174 opened this issue Jun 21, 2022 · 3 comments
Closed
3 tasks done

Support Jaeger Trace visualization with Flamegraph #1170

Rperry2174 opened this issue Jun 21, 2022 · 3 comments
Assignees

Comments

@Rperry2174
Copy link
Contributor

Rperry2174 commented Jun 21, 2022

There are two issues in Jaeger repo:

About visualizing trace data in Flamegraph form. Now that we have our @pyroscope/flamegraph npm package we could potentially make a slight modification to the code for the FlamegraphRenderer that would allow for us to:

  1. Transform trace data into a format that the flamegraph understands
  2. Visualize the trace data as a flamegraph

Worth noting that this tool: https://github.com/symbiont-io/jaeger-flamegraph takes a trace dump and turns it into a flamegraph.

I think the steps are:

image

For now we should do this in the pyroscope/jaeger-ui repo so we can test it out and see what it looks like and then later we will share with the jaeger team to get it merged upstream.

@eh-am
Copy link
Collaborator

eh-am commented Jul 7, 2022

Related #172

@Rperry2174
Copy link
Contributor Author

Note: They also have a "compare" page which calculates a diff. It would be cool if we could support that as well, but I think that would require us to move some of our go code into jaeger (or modularize it somehow)

image

@Rperry2174 Rperry2174 changed the title Support Trace visualization with Flamegraph Support Jaeger Trace visualization with Flamegraph Aug 1, 2022
@Rperry2174
Copy link
Contributor Author

Rperry2174 commented Aug 1, 2022

Completed in #1233 see example screenshotted below here

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants