Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro regex should be more strict #53

Closed
andresmgot opened this issue Nov 23, 2021 · 0 comments · Fixed by #55
Closed

Macro regex should be more strict #53

andresmgot opened this issue Nov 23, 2021 · 0 comments · Fixed by #55
Labels
bug Something isn't working effort/small good first issue Good for newcomers
Projects
[ARCHIVED] Cloud Datasources - Kanban

Comments

@andresmgot
Copy link
Collaborator

I attempted to add a new macro timeFilterEpoc while there is already a macro timeFilter. The problem is that the regex here is always matching timeFilter in all cases.
@andresmgot andresmgot added bug Something isn't working good first issue Good for newcomers labels Nov 23, 2021
@andresmgot andresmgot added this to Needs Triage in [ARCHIVED] Cloud Datasources - Kanban via automation Nov 23, 2021
@andresmgot andresmgot moved this from Needs Triage to Backlog in [ARCHIVED] Cloud Datasources - Kanban Nov 23, 2021
@fridgepoet fridgepoet mentioned this issue Dec 13, 2021
Merged
[ARCHIVED] Cloud Datasources - Kanban automation moved this from Backlog to Done Dec 14, 2021
@fionera fionera mentioned this issue Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working effort/small good first issue Good for newcomers
Projects
No open projects
[ARCHIVED] Cloud Datasources - Kanban
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make regex stricter on macro name matching grafana/sqlds
2 participants
@andresmgot @fridgepoet