Add blocklist_poll_jitter_ms config value
#1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
knylander-grafana,
KMiller-Grafana,
annanay25,
mdisibio,
dgzlopes,
mapno,
kvrhdn and
zalegrala
as code owners
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
knylander-grafana
approved these changes
Jun 28, 2022
zalegrala
approved these changes
Jun 28, 2022
|
Thanks for the reviews. I'm going to hold off on merging this for a bit. The environment that was showing these errors is now, inexplicably, not showing these errors. Even without the fix. I want to confirm this actually fixes something before merging. EDIT: I have seen now seen it once on the old image. I'm going to go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a configurable number of maximum milliseconds to sleep before pulling a block in the poller. This is useful when hosting on Azure to reduce pressure on DNS.
Which issue(s) this PR fixes:
Fixes #1462
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]