Fix a few inconsistencies in backend search between block formats #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, v2 substring on span name, v2 start/end optional
mdisibio
requested review from
joe-elliott,
annanay25,
dgzlopes,
mapno,
kvrhdn and
zalegrala
as code owners
annanay25
approved these changes
Jul 5, 2022
|
LGTM. Great to see parameterised tests on both versions, more to come |
3 tasks
joe-elliott
pushed a commit
to joe-elliott/tempo
that referenced
this pull request
Jul 7, 2022
…afana#1538) * Fix a few inconsistencies in search: vparquet handling of status code, v2 substring on span name, v2 start/end optional * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR fixes a few inconsistencies in backend search between block formats. But also this adds a set of search tests at the tempodb-level, that will help keep things consistent as we make more changes. Hint: I will be making more changes.
Fixes:
Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]