Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alert for failed polling of the blocklist #481

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Add alert for failed polling of the blocklist #481

merged 3 commits into from
Jan 28, 2021

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Jan 27, 2021 •
edited
Loading

What this PR does:

  • Adds alert and runbook for failure to poll blocklist
  • No longer considers it an error if a block does not have a meta or compacted block meta (this was artificially raising failure to poll blocklist)

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
Added alert and runbook entry
3f024a4 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Don't throw an error if a block doesn't have either meta
6463856 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
changelog
d16d9d0 
Signed-off-by: Joe Elliott <number101010@gmail.com>
annanay25
annanay25 approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice!

@joe-elliott joe-elliott merged commit 7837ea7 into grafana:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annanay25 annanay25 annanay25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joe-elliott @annanay25