Deprecate MaxSpansPerTrace in favour of MaxBytesPerTrace #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Annanay <annanayagarwal@gmail.com>
annanay25
requested review from
achatterjee-grafana,
dgzlopes,
joe-elliott and
mdisibio
as code owners
Signed-off-by: Annanay <annanayagarwal@gmail.com>
dgzlopes
reviewed
Mar 25, 2021
mdisibio
approved these changes
Mar 25, 2021
Signed-off-by: Annanay <annanayagarwal@gmail.com>
joe-elliott
approved these changes
Mar 25, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Annanay annanayagarwal@gmail.com
What this PR does:
Deprecates the
MaxSpansPerTracelimit imposed in the ingesters in favour of a byte based limitMaxBytesPerTracewhich gives a more predictable memory profile on the ingesters. This new limit protects from large traces that might have smaller span counts.Which issue(s) this PR fixes:
Fixes #na
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]