Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument AWS S3 requests with standard RED metrics #776

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

josephwoodward
Copy link
Contributor

@josephwoodward josephwoodward commented Jun 18, 2021

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@josephwoodward
Copy link
Contributor Author

Screenshot 2021-06-18 at 10 27 56

Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @josephwoodward!

@annanay25 annanay25 merged commit b22ebdc into grafana:main Jun 21, 2021
@josephwoodward
Copy link
Contributor Author

No problem @annanay25!

@josephwoodward josephwoodward deleted the AddS3Intrumentation branch June 21, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants